Fix page rule polish (off, lossless or lossy) (#116)

* allow polish to be "off","lossless" or "lossy"
cloudflare · Sep 18, 2018 · d6fd35e · d6fd35e
1 parent 68e829a
commit d6fd35e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/cloudflare/resource_cloudflare_page_rule.go b/cloudflare/resource_cloudflare_page_rule.go
@@ -89,12 +89,6 @@ func resourceCloudflarePageRule() *schema.Resource {
 							ValidateFunc: validation.StringInSlice([]string{"on", "off"}, false),
 						},
 
-						"polish": {
-							Type:         schema.TypeString,
-							Optional:     true,
-							ValidateFunc: validation.StringInSlice([]string{"on", "off"}, false),
-						},
-
 						"explicit_cache_control": {
 							Type:         schema.TypeString,
 							Optional:     true,
@@ -255,6 +249,12 @@ func resourceCloudflarePageRule() *schema.Resource {
 							Optional: true,
 						},
 
+						"polish": {
+							Type:         schema.TypeString,
+							Optional:     true,
+							ValidateFunc: validation.StringInSlice([]string{"off", "lossless", "lossy"}, false),
+						},
+
 						"resolve_override": {
 							Type:     schema.TypeString,
 							Optional: true,
@@ -499,7 +499,6 @@ var pageRuleAPIOnOffFields = []string{
 	"mirage",
 	"opportunistic_encryption",
 	"origin_error_page_pass_thru",
-	"polish",
 	"respect_strong_etag",
 	"response_buffering",
 	"rocket_loader",
@@ -525,6 +524,7 @@ var pageRuleAPIStringFields = []string{
 	"cache_level",
 	"cache_on_cookie",
 	"host_header_override",
+	"polish",
 	"resolve_override",
 	"security_level",
 	"ssl",

diff --git a/website/docs/r/page_rule.html.markdown b/website/docs/r/page_rule.html.markdown
@@ -55,6 +55,7 @@ Action blocks support the following:
 * `ip_geolocation` - (Optional) Whether this action is `"on"` or `"off"`.
 * `mirage` - (Optional) Whether this action is `"on"` or `"off"`.
 * `opportunistic_encryption` - (Optional) Whether this action is `"on"` or `"off"`.
+* `polish` - (Optional) Whether this action is `"off"`, `"lossless"` or `"lossy"`.
 * `resolve_override` - (Optional) Overridden origin server name.
 * `rocket_loader` - (Optional) Whether to set the rocket loader to `"on"`, `"off"`.
 * `security_level` - (Optional) Whether to set the security level to `"off"`, `"essentially_off"`, `"low"`, `"medium"`, `"high"`, or `"under_attack"`.