Add filtering flag for managed headers API (#1765)

Add filtering flag for managed headers API
cloudflare · Jul 26, 2022 · dbd8d9c · dbd8d9c
1 parent 00ee985
commit dbd8d9c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 22 deletions.
diff --git a/.changelog/1765.txt b/.changelog/1765.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/cloudflare_managed_headers: swap filtering to use API instead of custom logic
+```
diff --git a/internal/provider/resource_cloudflare_managed_headers.go b/internal/provider/resource_cloudflare_managed_headers.go
@@ -33,32 +33,19 @@ func resourceCloudflareManagedHeadersCreate(ctx context.Context, d *schema.Resou
 func resourceCloudflareManagedHeadersRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	client := meta.(*cloudflare.API)
 	zoneID := d.Get("zone_id").(string)
-	headers, err := client.ListZoneManagedHeaders(ctx, cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{})
-	if err != nil {
-		return diag.FromErr(fmt.Errorf("error reading managed headers: %w", err))
-	}
 
-	// Filter out headers that are not enabled. This will eventually move into
-	// the API endpoint or the SDK.
-	var enabledRequestHeaders []cloudflare.ManagedHeader
-	var enabledResponseHeaders []cloudflare.ManagedHeader
-
-	for _, header := range headers.ManagedRequestHeaders {
-		if header.Enabled {
-			enabledRequestHeaders = append(enabledRequestHeaders, header)
-		}
-	}
+	headers, err := client.ListZoneManagedHeaders(ctx, cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{
+		Status: "enabled",
+	})
 
-	for _, header := range headers.ManagedResponseHeaders {
-		if header.Enabled {
-			enabledResponseHeaders = append(enabledResponseHeaders, header)
-		}
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error reading managed headers: %w", err))
 	}
 
-	if err := d.Set("managed_request_headers", buildResourceFromManagedHeaders(enabledRequestHeaders)); err != nil {
+	if err := d.Set("managed_request_headers", buildResourceFromManagedHeaders(headers.ManagedRequestHeaders)); err != nil {
 		return diag.FromErr(err)
 	}
-	if err := d.Set("managed_response_headers", buildResourceFromManagedHeaders(enabledResponseHeaders)); err != nil {
+	if err := d.Set("managed_response_headers", buildResourceFromManagedHeaders(headers.ManagedResponseHeaders)); err != nil {
 		return diag.FromErr(err)
 	}
 	return nil
@@ -148,7 +135,10 @@ func resourceCloudflareManagedHeadersDelete(ctx context.Context, d *schema.Resou
 	client := meta.(*cloudflare.API)
 	zoneID := d.Get("zone_id").(string)
 
-	headers, err := client.ListZoneManagedHeaders(ctx, cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{})
+	headers, err := client.ListZoneManagedHeaders(ctx, cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{
+		Status: "enabled",
+	})
+
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error reading managed headers: %w", err))
 	}

diff --git a/internal/provider/resource_cloudflare_managed_headers_test.go b/internal/provider/resource_cloudflare_managed_headers_test.go
@@ -31,7 +31,9 @@ func testSweepCloudflareManagedHeaders(r string) error {
 		return errors.New("CLOUDFLARE_ZONE_ID must be set")
 	}
 
-	managedHeaders, err := client.ListZoneManagedHeaders(context.Background(), cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{})
+	managedHeaders, err := client.ListZoneManagedHeaders(context.Background(), cloudflare.ZoneIdentifier(zoneID), cloudflare.ListManagedHeadersParams{
+		Status: "enabled",
+	})
 	if err != nil {
 		tflog.Error(ctx, fmt.Sprintf("Failed to fetch Cloudflare Zone Managed Headers: %s", err))
 	}