-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudflare_record Terraform resource #1148
Labels
triage/unresolved
Indicates an issue that can not or will not be resolved.
Comments
isdinAghmir
added
kind/enhancement
Categorizes issue or PR as related to improving an existing feature.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Aug 3, 2021
jacobbednarz
added
triage/unresolved
Indicates an issue that can not or will not be resolved.
and removed
kind/enhancement
Categorizes issue or PR as related to improving an existing feature.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Aug 3, 2021
Not all records support this functionality so for now, I'm going to pass on implementing. If we get more requests in the future, we can revisit. |
boekkooi-lengoo
added a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this issue
Mar 10, 2022
Instead of trying and failing to calculate the requested validity of the certificate we can use the returned validity. It looks like `requested_validity` was being used in 2 ways. The first one was to request the certificate for a time period and the second to indicate the amount of day the certificate is still valid. The calculation is no longer done and could be seen as a BC break but since the current setup is causing issue like cloudflare#1148, cloudflare#1276 and cloudflare#1031. I expect that this is acceptable. Related API docs: https://api.cloudflare.com/#origin-ca-get-certificate
boekkooi-lengoo
added a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this issue
Mar 10, 2022
Instead of trying and failing to calculate the requested validity of the certificate we can use the returned validity. It looks like `requested_validity` was being used in 2 ways. The first one was to request the certificate for a time period and the second to indicate the amount of day the certificate is still valid. The calculation is no longer done and could be seen as a BC break but since the current setup is causing issue like cloudflare#1148, cloudflare#1276 and cloudflare#1031. I expect that this is acceptable. Related API docs: https://api.cloudflare.com/#origin-ca-get-certificate
boekkooi-lengoo
added a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this issue
Mar 10, 2022
Instead of trying and failing to calculate the requested validity of the certificate we can use the returned validity. It looks like `requested_validity` was being used in 2 ways. The first one was to request the certificate for a time period and the second to indicate the amount of day the certificate is still valid. The calculation is no longer done and could be seen as a BC break but since the current setup is causing issue like cloudflare#1148, cloudflare#1276 and cloudflare#1031. I expect that this is acceptable. Related API docs: https://api.cloudflare.com/#origin-ca-get-certificate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Terraform and Cloudflare provider version
2.24.0
Description
change the type of 'value' from string to list of string.
Use cases
Creating one record with multiple ips
Potential Terraform configuration
...
References
No response
The text was updated successfully, but these errors were encountered: