AUTH-3689: Adds support for access keys configuration #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GreenStage
commented
Sep 10, 2021
GreenStage
commented
- Documentation has already been updated. (https://api.cloudflare.com/#access-keys-configuration-properties)
- Depends on AUTH-3689: Adds support for access keys config endpoints cloudflare-go#704
| func resourceCloudflareAccessKeysConfigurationRead(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*cloudflare.API) | ||
|
|
||
| var keysConfig cloudflare.AccessKeysConfig |
There was a problem hiding this comment.
Suggested change
| var keysConfig cloudflare.AccessKeysConfig |
we can do away with this as client.AccessKeysConfig returns a cloudflare.AccessKeysConfig type and you assign it to keysConfig anyway
cloudflare/resource_cloudflare_access_keys_configuration_test.go
Outdated
Show resolved
Hide resolved
cloudflare/resource_cloudflare_access_keys_configuration_test.go
Outdated
Show resolved
Hide resolved
GreenStage
force-pushed
the
egomes/per-account-keys
branch
2 times, most recently
from
a9d447e to
406f59e
Compare
jacobbednarz
force-pushed
the
egomes/per-account-keys
branch
from
406f59e to
5a48cec
Compare
jacobbednarz
force-pushed
the
egomes/per-account-keys
branch
from
5a48cec to
d2becad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.