Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_zone_settings_override: add more supported properties #1261

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

jacobbednarz
Copy link
Member

  • binary_ast
  • filter_logs_to_cloudflare
  • log_to_cloudflare
  • orange_to_orange
  • visitor_ip
  • proxy_read_timeout

Closes #1165

@jacobbednarz jacobbednarz force-pushed the more-zone-overrides branch 2 times, most recently from 4a15d2f to c109af4 Compare October 18, 2021 02:48
…ties

- binary_ast
- filter_logs_to_cloudflare
- log_to_cloudflare
- orange_to_orange
- visitor_ip
- proxy_read_timeout

Closes #1165
@jacobbednarz jacobbednarz merged commit 4d9538b into master Oct 18, 2021
@jacobbednarz jacobbednarz deleted the more-zone-overrides branch October 18, 2021 02:55
github-actions bot pushed a commit that referenced this pull request Oct 18, 2021
@alex-feel
Copy link

Hi guys, it looks like binary_ast is no longer supported. Shouldn't it be removed?

@alex-feel
Copy link

alex-feel commented Dec 20, 2021

It also looks like proxy_read_timeout (it is a string type here) setting is not a string type according to the docs.

alex-feel added a commit to alex-feel/terraform-cloudflare-zone that referenced this pull request Dec 20, 2021
…ource

More info at cloudflare/terraform-provider-cloudflare#1261, cloudflare/terraform-provider-cloudflare#1285.

Note. It looks like the following settings are no longer supported: binary_ast, filter_logs_to_cloudflare, log_to_cloudflare, visitor_ip.
@Nuxij
Copy link

Nuxij commented May 13, 2022

@alex-feel are you going to make a new PR from your fork? Thank you for your work, but I don't want to depend on non-official sources, and the original authors here seem not to care?

@alex-feel
Copy link

@Nuxij I didn't fork this repo, I didn't work on it, so I can't make a PR. I'm only working on this module: https://github.com/alex-feel/terraform-cloudflare-zone, rather than on the provider itself.

@Nuxij
Copy link

Nuxij commented May 13, 2022

Oh sorry I misunderstood what your repo was! Should I switch to that module for an easier time? Modules have a bit more leeway than providers.

Edit: Nah stupid question, you will still need this provider surely. I guess I will just not do any settings until the provider is fixed.

@alex-feel
Copy link

Of course you decide, but I would try in your place) I can only add that I myself use this module in my work tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zone setting for orange_to_orange
3 participants