Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_zone_settings_override: Add support for early_hints #1285

Merged

Conversation

zaidoon1
Copy link

Adds documentation and functionality to support the use of early_hintsfor zone configurations.

Adds documentation and functionality to support the use of `early_hints`for zone configurations.
@zaidoon1 zaidoon1 force-pushed the zaidoon/add_early_hints_support branch from 5d0524e to 7ea0419 Compare October 29, 2021 00:13
@jacobbednarz
Copy link
Member

acceptance tests are all passing 🎉

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareZoneSettingsOverride_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareZoneSettingsOverride_Full
--- PASS: TestAccCloudflareZoneSettingsOverride_Full (33.61s)
=== RUN   TestAccCloudflareZoneSettingsOverride_RemoveAttributes
--- PASS: TestAccCloudflareZoneSettingsOverride_RemoveAttributes (46.09s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	80.002s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

congrats on your first PR @zaidoon1 🏆

@jacobbednarz jacobbednarz merged commit cda4375 into cloudflare:master Oct 29, 2021
alex-feel added a commit to alex-feel/terraform-cloudflare-zone that referenced this pull request Dec 20, 2021
…ource

More info at cloudflare/terraform-provider-cloudflare#1261, cloudflare/terraform-provider-cloudflare#1285.

Note. It looks like the following settings are no longer supported: binary_ast, filter_logs_to_cloudflare, log_to_cloudflare, visitor_ip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants