-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requested_validity
in cloudflare_origin_ca_certificate
is ignored as an input
#1448
Comments
Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of This issue has been marked with |
@jacobbednarz Thanks for the heads up! I've updated the issue to include the full debug output for all actions. |
thanks @acchiao. it looks like we're sending 0 as the requested validity timespan (and the service is defaulting to the longest) so will need to dig into why that is :/ |
👋 Is there any progress on this? |
Instead of trying and failing to calculate the requested validity of the certificate we can use the returned validity. It looks like `requested_validity` was being used in 2 ways. The first one was to request the certificate for a time period and the second to indicate the amount of day the certificate is still valid. The calculation is no longer done and could be seen as a BC break but since the current setup is causing issue like cloudflare#1448, cloudflare#1276 and cloudflare#1031. I expect that this is acceptable. Related API docs: https://api.cloudflare.com/#origin-ca-get-certificate
I think that this issue was fixed with the PR #1502 and can be closed. |
thanks @peruzzof |
Confirmation
Terraform and Cloudflare provider version
Affected resource(s)
Terraform configuration files
Debug output
Panic output
No response
Expected output
The expected output would be the
requested_validity
field being set to730
days in the Terraform plan.Actual output
The
requested_validity
parameter is interpreted as a computed field and defaults to5475
despite being set to730
.Steps to reproduce
requested_validity
parameter set to an accepted value besides5475
(ex:730
).requested_validity
in the plan output shows asrequested_validity = (known after apply)
.requested_validity
in the Terraform state is not what is expected and has defaulted to5475
.Additional factoids
No response
References
hashicorp/terraform-plugin-sdk#806
#1276
#1031
The text was updated successfully, but these errors were encountered: