Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages project should have deployments enabled by default #1924

Closed
SebastiaanYN opened this issue Sep 22, 2022 · 3 comments · Fixed by #1973
Closed

Pages project should have deployments enabled by default #1924

SebastiaanYN opened this issue Sep 22, 2022 · 3 comments · Fixed by #1973
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@SebastiaanYN
Copy link
Member

Current Terraform and Cloudflare provider version

Terraform v1.2.4
on darwin_amd64

  • provider registry.terraform.io/cloudflare/cloudflare v3.24.0
  • provider registry.terraform.io/hashicorp/vault v3.7.0

Description

Currently the default value for deployments_enabled in the pages_project resource is false. This should instead be true.

Use cases

Setting deployments_enabled to true by default or explicitly documenting that it's false by default would prevent unnecessary confusion surrounding a project being created but seeing no deployments.

Potential Terraform configuration

resource "cloudflare_pages_project" "example" {
  account_id        = var.account_id
  name              = "example"
  production_branch = "master"

  build_config {
    build_command   = "yarn build"
    destination_dir = "build"
  }

  source {
    type = "github"

    config {
      owner               = "cloudflare"
      repo_name           = "1.1.1.1"
      production_branch   = "master"
      pr_comments_enabled = false
    }
  }
}

References

No response

@SebastiaanYN SebastiaanYN added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 22, 2022
@WalshyDev
Copy link
Member

CC: @Cyb3r-Jak3

we default these if not provided but Terraform provides everything and does it's own defaulting.

Few other properties that should have specific defaults too which I can grab next week

@jacobbednarz
Copy link
Member

curious, is there a use case where we don't ever want a resource to automatically deploy? seems like this is the safe guard to prevent things from accidentally being deployed if another system manages it.

WalshyDev added a commit to WalshyDev/terraform-provider-cloudflare that referenced this issue Oct 15, 2022
WalshyDev added a commit to WalshyDev/terraform-provider-cloudflare that referenced this issue Oct 18, 2022
@github-actions github-actions bot added this to the v3.26.0 milestone Oct 18, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.26.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants