Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource "cloudflare_load_balancer" has no enabled field #208

Closed
SteveGoldthorpe-Work opened this issue Feb 11, 2019 · 9 comments
Closed

resource "cloudflare_load_balancer" has no enabled field #208

SteveGoldthorpe-Work opened this issue Feb 11, 2019 · 9 comments

Comments

@SteveGoldthorpe-Work
Copy link
Contributor

SteveGoldthorpe-Work commented Feb 11, 2019 •
edited
Loading

Terraform Version

Terraform v0.11.11

  • provider.cloudflare v1.11.0

Affected Resource(s)

Please list the resources as a list, for example:

  • cloudflare_load_balancer

Although not documented in the API docs, there is a parameter "enabled" which can have the value true or false. This has the effect of enabling or disabling the load balancer. The lack of this parameter means we turn the load balancer on or off or ensure it's in a given state.
@SteveGoldthorpe-Work SteveGoldthorpe-Work changed the title resource "cloudflare_rate_limit" has no response.headers field resource "* cloudflare_load_balancer" has no enabled field Feb 11, 2019
@SteveGoldthorpe-Work SteveGoldthorpe-Work changed the title resource "* cloudflare_load_balancer" has no enabled field resource "cloudflare_load_balancer" has no enabled field Feb 11, 2019
@SteveGoldthorpe-Work
Copy link
Contributor Author

I think this needs an update in cloudflare-go first.

@SteveGoldthorpe-Work
Copy link
Contributor Author

Raised issue:
cloudflare/cloudflare-go#272

@jacobbednarz
Copy link
Member

Awesome! Once this lands in cloudflare-go we can add it to Terraform. Until then, let's park this.

@SteveGoldthorpe-Work SteveGoldthorpe-Work mentioned this issue Mar 6, 2019
Merged
@jacobbednarz
Copy link
Member

This had landed upstream so if you want to add it, I'd happily review a PR for it. If not, I can take a look in the coming days.

@jacobbednarz jacobbednarz reopened this Mar 27, 2019
@SteveGoldthorpe-Work
Copy link
Contributor Author

I've already got the code stashed, will update and create PR tomorrow.

SteveGoldthorpe-Work added a commit to sgoldthorpe/terraform-provider-cloudflare that referenced this issue Apr 2, 2019
@SteveGoldthorpe-Work
Add enabled field to load_balancer (cloudflare#208)
c2381bf
@SteveGoldthorpe-Work SteveGoldthorpe-Work mentioned this issue Apr 2, 2019
Merged
patryk pushed a commit that referenced this issue Apr 2, 2019
@SteveGoldthorpe-Work @patryk
Add enabled field to load_balancer (#208) (#281)
0ca8e72 
* Add enabled field to load_balancer (#208)
* docs for enabled option of load-balancer resource.
@jallentech
Copy link

Thanks, this is a really useful piece of work. I was just wondering whether it will be available in the next release and when the next release is likely to happen?

@jacobbednarz
Copy link
Member

It will be in the next release but no ETA yet on when it will be cut. Shouldn't be too far away though.

@jallentech
Copy link

That's great, thanks for the update

@jacobbednarz
Copy link
Member

This was released in 1.13.0

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this issue Feb 28, 2022
@AshleyPoole @patryk
Add correlate (nat support) to rate limiting (cloudflare#208)
a011a83 
Add correlate (nat support) to rate limiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacobbednarz @SteveGoldthorpe-Work @jallentech