Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowed_match_count in DLP Profiles #2210

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Add allowed_match_count in DLP Profiles #2210

merged 6 commits into from
Feb 16, 2023

Conversation

pierreca
Copy link
Contributor

@pierreca pierreca commented Feb 1, 2023

Corresponding cloudflare-go PR: cloudflare/cloudflare-go#1193
released with v0.60.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

changelog detected ✅

Add allowed_match_count in DLP Profiles
864235d 
This requires updating cloudflare-go to 0.61.0

The field has been marked as "required" to avoid 0 value issues
@pierreca pierreca force-pushed the allowed_match_count branch from aec698c to 864235d Compare February 15, 2023 23:27
jacobbednarz
jacobbednarz reviewed Feb 16, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Feb 16, 2023
View reviewed changes
.changelog/2210.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDLPProfile_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDLPProfile_Custom
--- PASS: TestAccCloudflareDLPProfile_Custom (10.72s)
=== RUN   TestAccCloudflareDLPProfile_Custom_MultipleEntries
--- PASS: TestAccCloudflareDLPProfile_Custom_MultipleEntries (9.35s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount
--- PASS: TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount (9.69s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	30.330s

@jacobbednarz jacobbednarz merged commit d603cc8 into cloudflare:master Feb 16, 2023
@github-actions github-actions bot added this to the v3.35.0 milestone Feb 16, 2023
github-actions bot pushed a commit that referenced this pull request Feb 16, 2023
Update CHANGELOG.md for #2210
7bbc3c2
@github-actions
Copy link
Contributor

This functionality has been released in v3.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pierreca @jacobbednarz