Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sentinelone type in the cloudflare_device_posture_rule schema #2279

Merged

Conversation

aborrello
Copy link
Contributor

@aborrello aborrello commented Mar 9, 2023

Follow up PR for issue #2278.

Adds support for the sentinelone device posture rule type (which is undocumented, but used by some posture rules created in the dashboard). No additional input schema modifications need to be made as sentinelone appears to be an alias for / accept the same parameters as the application type.

Closes #2278

@aborrello aborrello requested a review from jacobbednarz as a code owner March 9, 2023 04:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

This pull request contains a CHANGELOG.md file which should only be modified by maintainers.

If you are looking to include a CHANGELOG entry, you should use the process documented at https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md instead.

In order for this pull request to be merged, you need remove the modifications to CHANGELOG.md.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

thanks for the issue and subsequent PR! i've pinged the team internally to confirm the stabilty of sentinelone as a configuration option here. i can't find anything in our docs which suggests this application type isn't yet stable enough to be relied upon public SDKs (and why this is important). device posture rules are moving fast which may also mean i just don't have the search fu to find the updated documentation for this.

i'll mark this one as pending for now but hopefully have an answer soon that we can move this PR in either direction.

in the meantime, if this is something you need outside of the main line, there are docs on running a custom version that can include your patch.

@jacobbednarz jacobbednarz added the workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. label Mar 9, 2023
@jacobbednarz
Copy link
Member

we don't have documentation for this so the team will need to get those out before we land this one. the team mentioned they may be able to get to this next week or so.

@jacobbednarz jacobbednarz merged commit 9df14b6 into cloudflare:master May 1, 2023
@jacobbednarz
Copy link
Member

docs have been updated and now include these values.

@github-actions github-actions bot added this to the v4.5.0 milestone May 1, 2023
github-actions bot pushed a commit that referenced this pull request May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

This functionality has been released in v4.5.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
@aborrello aborrello deleted the device-posture-rule-support-s1 branch May 31, 2023 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sentinelone type in the cloudflare_device_posture_rule schema
2 participants