Add nat support to rate limit #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-limiting-nat-support
…-limiting-nat-support
|
#101 updates to the latest stable master from |
|
@jacobbednarz sure if you're PR gets merged in first, then I'll remove the changes here... Else, I think if yours gets merged after mine that should work too, as you're raising the version above what I've updated it to. @patryk any preference? |
|
@AshleyPoole I would like that single PR dealt with a single problem, so if, for example, you need to update vendored library, then better to do separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds NAT (correlate) support for rate limiting.
This is dependent on the following PR for the Cloudflare-Go repo being merge first and referencing that new version - cloudflare/cloudflare-go#208