allow creating custom_hostname records without ssl
#1127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickysemenza
commented
Jul 8, 2021
| @@ -41,7 +41,7 @@ func resourceCloudflareCustomHostname() *schema.Resource { | |||
| }, | |||
| "ssl": { | |||
| Type: schema.TypeList, | |||
| Required: true, | |||
There was a problem hiding this comment.
not too familiar with if this is a breaking change / needs to be modified differently? My feeling is that it's OK since it's going from required -> optional and not the other direction
nickysemenza
force-pushed
the
nicky/custom-hostname-no-ssl
branch
from
15b7885 to
ab7e5aa
Compare
|
i've cherry picked this into #1131 to keep CI green while bumping dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on cloudflare/cloudflare-go#666, will need to be updated after cloudflare-go version is cut (temporarily pinning it)