Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruleset_managed_challenge_1436 #1443

Merged
merged 4 commits into from
Feb 12, 2022

Conversation

vences
Copy link
Contributor

@vences vences commented Feb 11, 2022

For #1436

Following change in go #1442 I added acceptance test and also updated the documentation for the action managed_challenge in rulesets

@vences
Copy link
Contributor Author

vences commented Feb 11, 2022

➜  terraform-provider-cloudflare git:(ruleset_managed_challenge_1436) ✗ TF_ACC=1 go test $(go list ./...) -v -run TestAccCloudflareRuleset_WAFManagedRulesetWithActionManagedChallenge
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareRuleset_WAFManagedRulesetWithActionManagedChallenge
=== PAUSE TestAccCloudflareRuleset_WAFManagedRulesetWithActionManagedChallenge
=== CONT  TestAccCloudflareRuleset_WAFManagedRulesetWithActionManagedChallenge
--- PASS: TestAccCloudflareRuleset_WAFManagedRulesetWithActionManagedChallenge (19.87s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/cloudflare  20.167s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz jacobbednarz force-pushed the ruleset_managed_challenge_1436 branch from ed4f69e to 041a7b0 Compare February 12, 2022 02:25
@jacobbednarz
Copy link
Member

thank you @vences, this is perfect!

@jacobbednarz jacobbednarz merged commit baf0c75 into cloudflare:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants