Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation and examples for Email Routing #1895

Merged

Conversation

marco-lancini
Copy link
Contributor

The current examples for the cloudflare_email_routing_rule and cloudflare_email_routing_rule_catch_all resources seem to be invalid.

This PR updates the examples to use the correct syntax. Tested and working with provider v.3.23.0

Expand for error logs
│ Error: Insufficient action blocks
│ 
│   on cloudflare-emails.tf line 9, in resource "cloudflare_email_routing_rule" "example":
│    9: resource "cloudflare_email_routing_rule" "example" {
│ 
│ At least 1 "action" blocks are required.
╵
╷
│ Error: Insufficient matcher blocks
│ 
│   on cloudflare-emails.tf line 9, in resource "cloudflare_email_routing_rule" "example":
│    9: resource "cloudflare_email_routing_rule" "example" {
│ 
│ At least 1 "matcher" blocks are required.
╵
╷
│ Error: Unsupported argument
│ 
│   on cloudflare-emails.tf line 13, in resource "cloudflare_email_routing_rule" "example":
│   13:   matcher = [
│ 
│ An argument named "matcher" is not expected here. Did you mean to define a block of type "matcher"?
╵
╷
│ Error: Unsupported argument
│ 
│   on cloudflare-emails.tf line 21, in resource "cloudflare_email_routing_rule" "example":
│   21:   action = [
│ 
│ An argument named "action" is not expected here. Did you mean to define a block of type "action"?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

changelog detected ✅

@jacobbednarz jacobbednarz merged commit af89047 into cloudflare:master Sep 8, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 8, 2022
@jacobbednarz
Copy link
Member

thanks @marco-lancini! 🎩

github-actions bot pushed a commit that referenced this pull request Sep 8, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.24.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants