resource/cloudflare_workers_kv: key to force creation of a new resource

.changelog/2044.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/cloudflare_workers_kv: `key` changes force creation of a new resource
+```

docs/resources/workers_kv.md

@@ -1,43 +1,48 @@
 ---
-layout: "cloudflare"
-page_title: "Cloudflare: cloudflare_workers_kv"
-description: Provides the ability to manage Cloudflare Workers KV features.
+page_title: "cloudflare_workers_kv Resource - Cloudflare"
+subcategory: ""
+description: |-
+  Provides a Workers KV Pair.
 ---
 
-# cloudflare_workers_kv
+# cloudflare_workers_kv (Resource)
 
-Provides a Workers KV Pair. _NOTE:_ This resource uses the Cloudflare account APIs. This requires setting the `CLOUDFLARE_ACCOUNT_ID` environment variable or `account_id` provider argument.
+Provides a Workers KV Pair.
+
+~> This resource uses the Cloudflare account APIs. This requires setting the
+`CLOUDFLARE_ACCOUNT_ID` environment variable or `account_id` provider argument.
 
 ## Example Usage
 
-```hcl
+```terraform
 resource "cloudflare_workers_kv_namespace" "example_ns" {
   title = "test-namespace"
 }
 
 resource "cloudflare_workers_kv" "example" {
   namespace_id = cloudflare_workers_kv_namespace.example_ns.id
-  key = "test-key"
-  value = "test value"
+  key          = "test-key"
+  value        = "test value"
 }
 ```
 
-## Argument Reference
+<!-- schema generated by tfplugindocs -->
+## Schema
 
-The following arguments are supported:
+### Required
 
-- `namespace_id` - (Required) The ID of the Workers KV namespace in which you want to create the KV pair
-- `key` - (Required) The key name
-- `value` - (Required) The string value to be stored in the key
+- `key` (String) Name of the KV pair. **Modifying this attribute will force creation of a new resource.**
+- `namespace_id` (String) The ID of the Workers KV namespace in which you want to create the KV pair. **Modifying this attribute will force creation of a new resource.**
+- `value` (String) Value of the KV pair.
 
-## Import
+### Read-Only
 
-Workers KV Namespace settings can be imported using it's ID. **Note:** Because the same key can exist in multiple namespaces, the ID is a composite key of the format <namespace_id>/<key>.
+- `id` (String) The ID of this resource.
 
-```
-$ terraform import cloudflare_workers_kv.example beaeb6716c9443eaa4deef11763ccca6/test-key
-```
+## Import
 
-where:
+Import is supported using the following syntax:
 
-- `beaeb6716c9443eaa4deef11763ccca6` is the ID of the namespace and `test-key` is the key
+```shell
+$ terraform import cloudflare_workers_kv.example <namespace_id>/<key_name>
+```

examples/resources/cloudflare_workers_kv/import.sh

@@ -0,0 +1 @@
+$ terraform import cloudflare_workers_kv.example <namespace_id>/<key_name>

examples/resources/cloudflare_workers_kv/resource.tf

@@ -0,0 +1,9 @@
+resource "cloudflare_workers_kv_namespace" "example_ns" {
+  title = "test-namespace"
+}
+
+resource "cloudflare_workers_kv" "example" {
+  namespace_id = cloudflare_workers_kv_namespace.example_ns.id
+  key          = "test-key"
+  value        = "test value"
+}

internal/provider/resource_cloudflare_worker_kv.go → internal/provider/resource_cloudflare_workers_kv.go

@@ -22,6 +22,7 @@ func resourceCloudflareWorkerKV() *schema.Resource {
 		Importer: &schema.ResourceImporter{
 			StateContext: resourceCloudflareWorkersKVImport,
 		},
+		Description: "Provides a Workers KV Pair.",
 	}
 }
 

internal/provider/resource_cloudflare_worker_kv_test.go → internal/provider/resource_cloudflare_workers_kv_test.go

@@ -19,7 +19,39 @@ func TestAccCloudflareWorkersKV_Basic(t *testing.T) {
 	resourceName := "cloudflare_workers_kv." + name
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheckAccount(t) },
+		PreCheck: func() {
+			testAccPreCheck(t)
+			testAccPreCheckAccount(t)
+		},
+		ProviderFactories: providerFactories,
+		CheckDestroy:      testAccCloudflareWorkersKVDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCheckCloudflareWorkersKV(name, key, value),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCloudflareWorkersKVExists(key, &kvPair),
+					resource.TestCheckResourceAttr(
+						resourceName, "value", value,
+					),
+				),
+			},
+		},
+	})
+}
+
+func TestAccCloudflareWorkersKV_NameForcesRecreation(t *testing.T) {
+	t.Parallel()
+	var kvPair cloudflare.WorkersKVPair
+	name := generateRandomResourceName()
+	key := generateRandomResourceName()
+	value := generateRandomResourceName()
+	resourceName := "cloudflare_workers_kv." + name
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheck(t)
+			testAccPreCheckAccount(t)
+		},
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCloudflareWorkersKVDestroy,
 		Steps: []resource.TestStep{
@@ -32,6 +64,16 @@ func TestAccCloudflareWorkersKV_Basic(t *testing.T) {
 					),
 				),
 			},
+			{
+				Config: testAccCheckCloudflareWorkersKV(name, key+"-updated", value),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCloudflareWorkersKVExists(key, &kvPair),
+					resource.TestCheckResourceAttr(
+						resourceName, "value", value,
+					),
+				),
+				ExpectNonEmptyPlan: false,
+			},
 		},
 	})
 }

internal/provider/schema_cloudflare_workers_kv.go

@@ -0,0 +1,25 @@
+package provider
+
+import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+
+func resourceCloudflareWorkerKVSchema() map[string]*schema.Schema {
+	return map[string]*schema.Schema{
+		"key": {
+			Type:        schema.TypeString,
+			ForceNew:    true,
+			Required:    true,
+			Description: "Name of the KV pair.",
+		},
+		"namespace_id": {
+			Type:        schema.TypeString,
+			ForceNew:    true,
+			Required:    true,
+			Description: "The ID of the Workers KV namespace in which you want to create the KV pair.",
+		},
+		"value": {
+			Type:        schema.TypeString,
+			Required:    true,
+			Description: "Value of the KV pair.",
+		},
+	}
+}

templates/resources/workers_kv.md.tmpl

@@ -0,0 +1,25 @@
+---
+page_title: "{{.Name}} {{.Type}} - {{.RenderedProviderName}}"
+subcategory: ""
+description: |-
+{{ .Description | plainmarkdown | trimspace | prefixlines "  " }}
+---
+
+# {{.Name}} ({{.Type}})
+
+{{ .Description | trimspace }}
+
+~> This resource uses the Cloudflare account APIs. This requires setting the
+`CLOUDFLARE_ACCOUNT_ID` environment variable or `account_id` provider argument.
+
+## Example Usage
+
+{{ tffile (printf "%s%s%s" "examples/resources/" .Name "/resource.tf") }}
+
+{{ .SchemaMarkdown | trimspace }}
+
+## Import
+
+Import is supported using the following syntax:
+
+{{ codefile "shell" (printf "%s%s%s" "examples/resources/" .Name "/import.sh") }}