tests: Fix cloudflare_load_balancer acceptance tests #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This avoid spurious diffs of this resource when `steering_policy` is not defined in config
as demonstrated by this failing test:
```
--- FAIL: TestAccCloudflareLoadBalancer_CreateAfterManualDestroy (4.08s)
testing.go:527: Step 1 error: After applying this step, the plan was not empty:
DIFF:
UPDATE: cloudflare_load_balancer.vmc92sw22l
steering_policy: "off" => ""
```
- We cannot set `Default` for this field because default value varies
based on other settings (per API docs)
- This helps us to detect any drifts (changes outside of Terraform)
and make import work correctly, i.e. fix this test failure:
```
--- FAIL: TestAccCloudflareLoadBalancer_Import (2.90s)
testing.go:527: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=16) "session_affinity": (string) (len=4) "none"
}
```
|
Also I'm thinking we should perhaps update the docs (both API and Terraform) to make it clear that FQDN (incl. the zone) is expected. |
ghost
added
the
kind/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the following 6 test failures (and some others which are surfaced once the original problem w/ incorrect LB name is fixed).
I'm not sure if the LB resource should just automatically stick the zone name at the end of LB name if it's missing, but that is IMO a discussion for a separate issue/PR. This is aiming to merely fix existing failing tests.