Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1943 - add data_source_rulesets #2220

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

helloandre
Copy link

adds support for data "cloudflare_rulesets"

example:

data "cloudflare_rulesets" "cmr" {
  zone_id = var.zone_id

  filter {
    name = "Cloudflare Managed Ruleset"
  }
}

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

thanks for this @helloandre 🙇 couple of things we need to do in order to get this one over the line:

there are a couple of questions inline that hopefully make sense but if they don't, let me know and i'll elaborate on them some more 😄

@jacobbednarz
Copy link
Member

acceptance tests all looking good!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareRulesetsProviderDataSource_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareRulesetsProviderDataSource_PreventZoneIdAndAccountIdConflicts
--- PASS: TestAccCloudflareRulesetsProviderDataSource_PreventZoneIdAndAccountIdConflicts (2.29s)
=== RUN   TestAccCloudflareRulesetsProviderDataSource_RequireOneOfZoneAccountID
--- PASS: TestAccCloudflareRulesetsProviderDataSource_RequireOneOfZoneAccountID (1.81s)
=== RUN   TestAccCloudflareRulesetsProviderDataSource_FetchOWASPRulesetByName
--- PASS: TestAccCloudflareRulesetsProviderDataSource_FetchOWASPRulesetByName (8.63s)
=== RUN   TestAccCloudflareRulesetsProviderDataSource_FetchOWASPRulesetByID
--- PASS: TestAccCloudflareRulesetsProviderDataSource_FetchOWASPRulesetByID (8.35s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	21.702s

@jacobbednarz jacobbednarz merged commit 6ca78e3 into cloudflare:master Feb 9, 2023
@github-actions github-actions bot added this to the v3.35.0 milestone Feb 9, 2023
github-actions bot pushed a commit that referenced this pull request Feb 9, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v3.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants