APILIB-901: h2_prioritization setting not able to be set in bulk #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Have we got a way to assert that this is working? Would an integration test cover the expectations here? |
|
An alternative option: Should we just send all settings to their direct endpoint instead of using the bulk endpoint to minimise the code complexity? It would be more HTTP requests but the big upside is that we would have less code paths in the provider code. |
|
It is expected all zone settings have their own endpoints, so yeah, it's entirely logical we can streamline the code this way and get rid of edge case logic. Also, integration test would be a nice to have and would validate the issue fixed here. |
nlamirault
added a commit
to nlamirault/terraform-provider-cloudflare
that referenced
this pull request
Oct 8, 2019
…-sdk * upstream/master: Update google.golang.org/genproto commit hash to a023cd5 addon zone settings info about default values (cloudflare#498) APILIB-901: h2_prioritization setting not able to be set in bulk (cloudflare#493) Update google.golang.org/genproto commit hash to c459b9c Update google.golang.org/genproto commit hash to 455060b Update module cloudflare/cloudflare-go to v0.10.3 (cloudflare#491)
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the API is fronted by API Gateway which routes various endpoints into different upstreams,
h2_prioritizationcannot be set through general/zone/settingsendpoint. We need to call it directly as a separate API call.