cloudflare_zone: add verification_key attribute #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
kind/documentation
patryk
approved these changes
Oct 15, 2019
|
We're good with this one despite the test failing (for now)? |
|
Hi @patryk I was able to setup an Enterprise zone with a custom built provider. I'd like to do an additional test to validate if #488 is impacting here too, then your call or @jacobbednarz for when it's safe to merge 😄 |
|
I'm on the fence; I'd really rather not have the integration tests failing on master as that is helpful to know whether changes in the codebase or Cloudflare API have introduced regressions. |
Introduces support for Access Service Tokens[1] as an available resource [1]: https://api.cloudflare.com/#access-service-tokens-properties
|
This now passes locally but not in CI 🤔 |
When we initially put the zone sweeper into place, it was in a shared
account that we couldn't just remove everything. This meant the
`ListZones` needed to only look up the zones we were expecting to
remove and clear those out. This is no longer the case as the tests run
against a dedicated account so we can blow everything away that isn't
the static `cfapi.net` domains (`terraform` and `terraform2`).
Fixes the following integration test failure.
```
=== RUN TestAccCloudflareZoneBasic
--- FAIL: TestAccCloudflareZoneBasic (0.79s)
testing.go:569: Step 0 error: errors during apply:
Error: Error creating zone "example.cfapi.net": error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1061,\"message\":\"example.cfapi.net already exists\"}],\"messages\":[],\"result\":null}"
on /opt/teamcity-agent/temp/buildTmp/tf-test007851057/main.tf line 2:
(source code not available)
FAIL
```
Updates the certificates used for custom SSL to prevent exceptions with
the expiry.
```
=== RUN TestAccCloudflareCustomSSL_Basic
=== PAUSE TestAccCloudflareCustomSSL_Basic
=== CONT TestAccCloudflareCustomSSL_Basic
--- FAIL: TestAccCloudflareCustomSSL_Basic (0.28s)
testing.go:569: Step 0 error: errors during apply:
Error: Failed to create custom ssl cert: error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1206,\"message\":\"The certificate will expire within soon. Please supply a newer one\"}],\"messages\":[],\"result\":null}"
on /opt/teamcity-agent/temp/buildTmp/tf-test656714404/main.tf line 2:
(source code not available)
FAIL
```
|
@jacobbednarz what kind of error arises in CI? I was able to do an E2E creation of Enterprise zone using the provider built with this version |
The Access Service Tokens endpoints unfortunately don't support API
tokens (the default authentication mechanism used in the tests) so we
need to unset it during test runs until this is resolved. It throws a
very confusing "insufficient permissions" exception.
```
=== RUN TestAccAccessServiceTokenCreate
--- FAIL: TestAccAccessServiceTokenCreate (0.56s)
testing.go:569: Step 0 error: errors during apply:
Error: error creating access service token: error from makeRequest: HTTP status 403: insufficient permissions
on /opt/teamcity-agent/temp/buildTmp/tf-test595601124/main.tf line 2:
(source code not available)
FAIL
```
…ccess-service-tokens * Add support for Access Service Tokens Introduces support for Access Service Tokens[1] as an available resource [1]: https://api.cloudflare.com/#access-service-tokens-properties
|
The failure is But locally, it works as expected. I haven't had a chance to dig into this yet though. Might need another merge from master to get the partial support stuff in here? |
Fix typo, require zone_id instead of zone
…ithub.com-hashicorp-terraform-plugin-sdk-1.x Update module hashicorp/terraform-plugin-sdk to v1.2.0
|
Hi @jacobbednarz I rebased from master including chages that fix #488 can you please verify this goes through CI? |
Merged
|
Re-applied this in #532 as this one is messy due to merge updates. |
jacobbednarz
added a commit
that referenced
this pull request
Nov 3, 2019
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #492, fixes #280