ci: fix acceptance tests

[mgirouard]

• I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Additional context & links

[vaishakdinesh]

This is all you need i think.
And with the above, this line will ignore items on import anyway

[mgirouard]

Unfortunately this doesn't seem to be enough:

mgirouard@sixteen:~/src/terraform-provider-cloudflare$ git diff
diff --git a/internal/services/list/resource_test.go b/internal/services/list/resource_test.go
index d6e9a5e4f0..9fb842d187 100644
--- a/internal/services/list/resource_test.go
+++ b/internal/services/list/resource_test.go
@@ -620,7 +620,7 @@ func TestAccCloudflareList_ImportWithSeparateListItem(t *testing.T) {
                                        return fmt.Sprintf("%s/%s", accountID, s.RootModule().Resources[resourceNameList].Primary.ID), nil
                                },
                                ImportStateVerify:       true,
-                               ImportStateVerifyIgnore: []string{"modified_on", "num_items"},
+                               ImportStateVerifyIgnore: []string{"modified_on", "num_items", "items"},
                                Check: resource.ComposeTestCheckFunc(
                                        resource.TestCheckResourceAttr(resourceNameList, "account_id", accountID),
                                        resource.TestCheckResourceAttr(resourceNameList, "name", listName),

mgirouard@sixteen:~/src/terraform-provider-cloudflare$ TF_ACC=1 go test ./internal/services/list/... -run ^TestAccCloudflareListWithItems_IP -v -count=1
=== RUN   TestAccCloudflareListWithItems_IP_Datasource
--- PASS: TestAccCloudflareListWithItems_IP_Datasource (9.93s)
=== RUN   TestAccCloudflareListWithItems_IP
    resource_test.go:357: Step 3/6 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.

          map[string]string{
        -       "items.#":    "2",
        -       "items.0.%":  "5",
        -       "items.0.ip": "1.1.1.1",
        -       "items.1.%":  "5",
        -       "items.1.ip": "1.1.1.2",
          }
--- FAIL: TestAccCloudflareListWithItems_IP (7.11s)
FAIL
FAIL    github.com/cloudflare/terraform-provider-cloudflare/internal/services/list      17.051s
FAIL

[vaishakdinesh]

hmmm. @broswen what do you think?

[mgirouard]

I'm fine with pulling this from my patch, but we'll need to get the acceptance tests running else we can't release. Tests run fine when I check out the previous release tag.

[broswen]

This is all you need i think. And with the above, this line will ignore items on import anyway

It looks like you added it to a different test than what was failing?

TestAccCloudflareList_ImportWithSeparateListItem vs TestAccCloudflareListWithItems_IP

I wonder if there is a way to validate what ImportState is doing for cloudflare_list with the test framework.

We want to validate that imports do not load any list items into the nested items property. But on the next plan/read it will load them dynamically if items is set.

We'll probably have to use ImportStateCheck or ImportPlanChecks

[broswen]

I think the commits related to this change should be reverted.
#6262

Import is actually not working on all configurations for this resource.

[mgirouard]

ACK 👍 Will pull it out.

[broswen]

I don't think it's actually possible what I was trying to do there because Read doesn't give you access to the config state.

[mgirouard]

Removed my patch in ef07f5e...98723b3

[mgirouard]

Revert PR is here: #6389