Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-95: cache_ttl_by_status support for Page Rules #706

Merged
merged 2 commits into from
Jun 17, 2020
Merged

SDK-95: cache_ttl_by_status support for Page Rules #706

merged 2 commits into from
Jun 17, 2020

Conversation

patryk
Copy link
Contributor

@patryk patryk commented Jun 11, 2020

@ghost ghost added the size/M label Jun 11, 2020
@patryk patryk force-pushed the feature/SDK-95_cache_ttl_by_status branch from cb21356 to 9a1c6b5 Compare June 12, 2020 11:39
@ghost ghost added size/L kind/documentation Categorizes issue or PR as related to documentation. and removed size/M labels Jun 12, 2020
@patryk patryk marked this pull request as ready for review June 12, 2020 12:01
@jacobbednarz jacobbednarz mentioned this pull request Jun 15, 2020
Closed
@jacobbednarz
Copy link
Member

jacobbednarz commented Jun 15, 2020 •
edited
Loading

Closes #711

Will review this tomorrow (AEST)

@jacobbednarz jacobbednarz linked an issue Jun 15, 2020 that may be closed by this pull request
Add support for Cache TTL by status code #711
Closed
jacobbednarz
jacobbednarz approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with a question on swapping out a hardcoded resource name for a randomly generated one.

@jacobbednarz
Don't hardcode test resource name values
04fa7ca 
Avoids hardcoding in "test" resource names as they can hide issues when
resources are not cleaned up properly.
@jacobbednarz jacobbednarz merged commit cd0cff7 into master Jun 17, 2020
@jacobbednarz
Copy link
Member

🍻 thanks @patryk!

@jacobbednarz jacobbednarz deleted the feature/SDK-95_cache_ttl_by_status branch June 17, 2020 05:56
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
@jacobbednarz
Merge pull request cloudflare#706 from GreenStage/egomes/knock
da82209 
AUTH-3794: Adds support for approval groups in access policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz approved these changes

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Cache TTL by status code
2 participants
@patryk @jacobbednarz