Fixed crash in Page Rules update when using custom cache key #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
approved these changes
Dec 17, 2020
| func TestCacheKeyFieldsNilValue(t *testing.T) { | ||
| pageRuleAction, err := transformToCloudflarePageRuleAction( | ||
| "cache_key_fields", | ||
| []interface{}{map[string]interface{}{"cookie": []interface{}{map[string]interface{}{"check_presence": []interface{}{}, "include": []interface{}{"next-i18next"}}}, "header": []interface{}{map[string]interface{}{"check_presence": []interface{}{}, "exclude": []interface{}{}, "include": []interface{}{"x-forwarded-host"}}}, "host": []interface{}{map[string]interface{}{"resolved": false}}, "query_string": []interface{}{interface{}(nil)}, "user": []interface{}{map[string]interface{}{"device_type": true, "geo": true, "lang": true}}}}, |
There was a problem hiding this comment.
This is the exact setting that triggers crash for the used who reported it. Put here as a regression test.
| @@ -866,18 +866,23 @@ func transformToCloudflarePageRuleAction(id string, value interface{}, d *schema | |||
| for sectionID, sectionValue := range cacheKeyActionSchema[0].(map[string]interface{}) { | |||
| sectionOutput := map[string]interface{}{} | |||
|
|
|||
| for fieldID, fieldValue := range sectionValue.([]interface{})[0].(map[string]interface{}) { | |||
| sectionOutput[fieldID] = fieldValue | |||
| if sectionValue.([]interface{})[0] != nil { | |||
There was a problem hiding this comment.
just checking "" and 0 aren't possible here either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when the existing Page Rule that did not have
custom_cache_keyis updated to have one.