Skip to content

Conversation

@ssicard
Copy link
Collaborator

@ssicard ssicard commented Nov 5, 2025

Supports migrations of the logpush_job resource from v4 to v5. Will migrate the following:

  • rename attribute in output_options of cve20214428 to cve_2021_44228
  • any kind of "instant-logs" is no longer supported. It now transforms into ""
  • max_upload_bytes, max_upload_records, and max_upload_interval_seconds all convert from an int to Float64
    • These values are all removed if set to 0 (which is not a valid value for any of them, just the null default in v4)
  • convert output_options from block to attribute
    • The defaults for output options are explicitly set in v4, and show in state. In order to have parity, we explicitly set them in config and state in v5.

@vaishakdinesh vaishakdinesh added this to the Phase 1 milestone Nov 5, 2025
vaishakdinesh
vaishakdinesh previously approved these changes Nov 7, 2025
@ssicard ssicard marked this pull request as draft November 11, 2025 20:26
@ssicard ssicard marked this pull request as ready for review November 12, 2025 16:58
@ssicard ssicard dismissed vaishakdinesh’s stale review November 12, 2025 17:13

This is a stale review, and substantial changes have been added since regarding:

  • explicitly setting v4 defaults in the v5 config and state
  • removing any kind set to "instant-logs" as the v5 default will set it to ""
@tamas-jozsa
Copy link
Collaborator

Could you rebase + improve the comprehensiveness of the integration testdata using prompt:subtask_08?

@SirCortly SirCortly self-requested a review November 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants