-
Notifications
You must be signed in to change notification settings - Fork 1
feat: v4 to v5 migrations - logpush_job #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ssicard
wants to merge
14
commits into
main
Choose a base branch
from
ssicard/logpush-job
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaishakdinesh
previously approved these changes
Nov 7, 2025
SirCortly
approved these changes
Nov 12, 2025
…tested in int tests
This is a stale review, and substantial changes have been added since regarding:
- explicitly setting v4 defaults in the v5 config and state
- removing any
kindset to "instant-logs" as the v5 default will set it to ""
Collaborator
|
Could you rebase + improve the comprehensiveness of the integration testdata using prompt:subtask_08? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports migrations of the logpush_job resource from v4 to v5. Will migrate the following:
cve20214428tocve_2021_44228kindof "instant-logs" is no longer supported. It now transforms into ""max_upload_bytes,max_upload_records, andmax_upload_interval_secondsall convert from an int to Float64output_optionsfrom block to attribute