Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates deps and fixes tests for CommonJS and ESModules. #41

Merged
merged 10 commits into from
Sep 7, 2023

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Sep 2, 2023

Changes:

  • Tests must run for both ESM and CJS.
  • Updates and ping dependencies.
  • known bug: Jest doesn't recognize collectCoverage and verbose from configuration.
  • Fix bench compilation

Fixes #30

@armfazh armfazh added the fix-a-bug Fixes a bug in code label Sep 2, 2023
@armfazh armfazh requested a review from thibmeu September 2, 2023 00:10
@armfazh armfazh self-assigned this Sep 2, 2023
Copy link
Contributor

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, apart from coverage which does not work and prints warnings

mockCrypto/tsconfig.json Show resolved Hide resolved
jest.config.mjs Show resolved Hide resolved
@armfazh armfazh requested a review from thibmeu September 6, 2023 18:34
@armfazh armfazh merged commit 5cd324d into cloudflare:main Sep 7, 2023
3 checks passed
@armfazh armfazh deleted the fixDefault branch September 7, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-a-bug Fixes a bug in code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commonjs support?
2 participants