[nfc] Update bazel to 7.0.1, clean up git-based dependencies and related documentation #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Based on bazelbuild/bazel#16064 git_repository supports the same arguments as new_git_repository and the latter should no longer be used. - Update documentation to reflect that v8 is now used as a http_archive dependency.
Based on bazelbuild/bazel#12857 shallow_since may actually slow down the build. As of version 6.1.0, bazel no longer prints a warning if shallow_since is absent.
Among other changes this fixes several issues with /tmp in the sandbox that were introduced in 7.0.0.
|
CC @jasnell here's the documentation cleanup based on v8 no longer being fetched using git. |
Warfields
reviewed
Jan 19, 2024
| @@ -172,11 +172,10 @@ http_archive( | |||
| # old for tcmalloc. Absurdly, Bazel simply ignores later attempts to define the same repo name, | |||
| # rather than erroring out. Thus this leads to confusing compiler errors in tcmalloc complaining | |||
| # that ABSL_ATTRIBUTE_PURE_FUNCTION is not defined. | |||
| new_git_repository( | |||
There was a problem hiding this comment.
What's the difference between these sources?
There was a problem hiding this comment.
There was a difference in the past – new_git_repository() supports a build_file argument for importing a repository that does not have a pre-existing bazel build file. However, git_repository() has been updated as of bazel 6.1.0 to also have that argument so that only one function is needed. new_git_repository() is set to be removed in a future version, see bazelbuild/bazel#16064 for details. Currently both versions are supported, but only using one of them looks cleaner.
jasnell
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR to follow. I don't feel entirely sure about dropping shallow_since but if I interpret bazelbuild/bazel#12857 correctly it will only be faster in edge cases while being slower otherwise as
--depth 1is not being used.