Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes parsing of imports in multi-line string literals. #2810

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fixes parsing of imports in multi-line string literals. #2810

merged 1 commit into from
Sep 30, 2024

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Sep 26, 2024

No description provided.

@dom96 dom96 force-pushed the dominik/fixes-import-parser-for-multi-line-strings branch from 519e8d0 to 18e4cd0 Compare September 27, 2024 17:05
@dom96 dom96 marked this pull request as ready for review September 27, 2024 17:07
@dom96 dom96 requested review from a team as code owners September 27, 2024 17:07
hoodmane
hoodmane approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/workerd/api/pyodide/pyodide-test.c++ Outdated Show resolved Hide resolved
@dom96 dom96 force-pushed the dominik/fixes-import-parser-for-multi-line-strings branch from 18e4cd0 to 81427e7 Compare September 30, 2024 08:37
@dom96 dom96 force-pushed the dominik/fixes-import-parser-for-multi-line-strings branch from 81427e7 to f5896ed Compare September 30, 2024 09:25
@dom96 dom96 merged commit 3800fd6 into main Sep 30, 2024
14 checks passed
@dom96 dom96 deleted the dominik/fixes-import-parser-for-multi-line-strings branch September 30, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jclee jclee jclee left review comments

@hoodmane hoodmane hoodmane approved these changes

@harrishancock harrishancock Awaiting requested review from harrishancock harrishancock is a code owner automatically assigned from cloudflare/workers-runtime-1

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

@jp4a50 jp4a50 Awaiting requested review from jp4a50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dom96 @jclee @hoodmane