Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include implicit stdlib snapshot imports in package snapshot key. #2840

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Don't include implicit stdlib snapshot imports in package snapshot key. #2840

merged 1 commit into from
Oct 3, 2024

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Oct 2, 2024

These are always imported so it doesn't make sense to include them in the snapshot filename.

@dom96 dom96 requested review from a team as code owners October 2, 2024 14:40
@hoodmane
Copy link
Contributor

hoodmane commented Oct 2, 2024

Thanks!

@dom96 dom96 merged commit e8f21f4 into main Oct 3, 2024
14 checks passed
@dom96 dom96 deleted the dominik/skip-snapshot-imports branch October 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@hoodmane hoodmane hoodmane approved these changes

@danlapid danlapid Awaiting requested review from danlapid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dom96 @hoodmane @jasnell