Changes to enable download of snapshot in validator. #2843
+90
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
previously approved these changes
Oct 4, 2024
anonrig
approved these changes
Oct 4, 2024
|
|
||
| kj::HashSet<kj::String> filteredImports; | ||
| for (auto& import: imports) { | ||
| if (filteredImports.contains(import)) { |
There was a problem hiding this comment.
Nit:
Suggested change
| if (filteredImports.contains(import)) { | |
| if (filteredImports.contains(import)) [[unlikely]] { |
| kj::Array<kj::String> ArtifactBundler::filterPythonScriptImports( | ||
| kj::HashSet<kj::String> locals, kj::Array<kj::String> imports) { | ||
| kj::HashSet<kj::StringPtr> snapshotImportsSet; | ||
| for (auto import: ArtifactBundler::getSnapshotImports()) { |
There was a problem hiding this comment.
Suggested change
| for (auto import: ArtifactBundler::getSnapshotImports()) { | |
| for (auto& import: ArtifactBundler::getSnapshotImports()) { |
| } | ||
|
|
||
| kj::Array<kj::StringPtr> ArtifactBundler::getSnapshotImports() { | ||
| kj::StringPtr imports[] = {"_pyodide.docstring"_kj, "_pyodide._core_docs"_kj, "traceback"_kj, |
There was a problem hiding this comment.
Afaik, this can be constexpr. I added this to KJ, but I wonder if we are using the latest version right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor changes/clean up for the EW PR.