fix: Pass ctx.props to default handlers

[tewaro]

No description provided.

[github-actions]

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

[jasnell]

What exactly is the intent here? The PR description needs some explanation and detail. If the idea is to give every invocation it's own unique context, then rather than cloning the entire thing the way this PR does, could it make sense to simply wrap the context in a JS Proxy object for every request and either CoW the underlying context or just intercept mutations so that the original remains unmodified? The per-request props can then be injected via the proxy. Wrapping in a proxy could likely reduce much of the complexity here.

[kentonv]

What exactly is the intent here? The PR description needs some explanation and detail.

The goal of the change is to fix a known bug in which ctx.props is not available for non-class-based entrypoints because such entrypoints have always reused the same ctx object for all invocations. There's a comment on line 1674 describing the issue:

                        // TODO(cleanup): Unfortunately, for non-class-based handlers, we have
                        //   always created only a single `ctx` object and reused it for all
                        //   requests. This is weird and obviously wrong but changing it probably
                        //   requires a compat flag. Until then, connection properties will not be
                        //   available for non-class handlers.

BTW @tewaro we should update that comment to something like:

"Historically, non-class-based handlers reused the same ctx object for all requests. This was an accident, but some Workers depend on it. Newer worker with the unique_ctx_per_invocation will allocate a new ctx for every request."

Wrapping in a proxy could likely reduce much of the complexity here.

That sounds way more complicated to me. This change as-is is really not very complex at all. I don't see what benefit a Proxy would provide here.

[tewaro]

@kentonv how do I force the feature flag on all tests? do I need to modify each one?

[tewaro]

The above and below commits are to show that all tests pass with the change.
Edit: The feature flag will be added back in after they have passed.

[danlapid]

This should still have a unit test though.

[tewaro]

Unit tests added.
Commit f14be28 shows that all tests pass with the new behavior.
Commit f0e7b21 adds back the compatability flags checks.

[kentonv]

Internal build failure looks like a flake.