Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use_plus_in_repo_names for common options #3492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ujohnny
Copy link

@ujohnny ujohnny commented Feb 7, 2025

Bazel 7 uses ~ in external repo names and it leads to various issues like bazelbuild/bazel#23127 or some tools consider such paths as ignored because tilde could mean a backup copy of the file. Bazel 8 addresses these issues with use of + by default, but Bazel 7 must be supplied with an incompatible argument to enable this behavior

Bazel 7 uses ~ in external repo names and it leads to
various issues like bazelbuild/bazel#23127 or some tools
consider such paths as ignored because tilde could mean
a backup copy of the file. Bazel 8 addresses these issues
with use of + by default, but Bazel 7 must be supplied with
an incompatible argument to enable this behavior
@ujohnny ujohnny requested review from a team as code owners February 7, 2025 14:44
Copy link

github-actions bot commented Feb 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ujohnny
Copy link
Author

ujohnny commented Feb 7, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 7, 2025
@danlapid danlapid requested review from mikea and fhanau February 8, 2025 00:05
Copy link
Collaborator

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've personally never encountered difficulties with this (as I understand it mostly matters on Windows?), but while the Bazel 8 update is blocked I can see some developers having issues with this – LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants