rust-python-parser tidy up #3503
Open
+53
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
commented
Feb 9, 2025
| namespace workerd { | ||
| namespace rust { | ||
| namespace python_parser { | ||
| ::rust::Vec<::rust::String> get_imports(::rust::Slice<::rust::Str const> sources); |
There was a problem hiding this comment.
I don't love declaring this manually, but at least C++ name mangling means there is a very high probability of a link error rather than generating a bad executable if the declaration is wrong. The problem is this is declared in workerd/rust/python-parser/lib.rs.h which is generated by wd_rust_crate but that is a dependent of the rule that compiles cxx-bridge.c++. This probably means I'm doing something wrong in Bazel? cc @mikea
hoodmane
force-pushed
the
hoodmane/rust-python-parser-tidy
branch
2 times, most recently
from
d086e36 to
b968057
Compare
danlapid
reviewed
Feb 10, 2025
hoodmane
force-pushed
the
hoodmane/rust-python-parser-tidy
branch
from
b968057 to
c1a11df
Compare
1. Tests move into a different compilation unit from logic 2. Put the `parseImports` function into the same statib library as the rust objects.
hoodmane
force-pushed
the
hoodmane/rust-python-parser-tidy
branch
from
c1a11df to
e2adb8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseImportsfunction into the same statib library as the rust objects.