feat: add Workflows to ValidationErrorReporter #3509
+42
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisDuarte1
force-pushed
the
lduarte/workflows-validator
branch
from
eda2f27 to
536b134
Compare
a-robinson
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Approving since this is identical to #3481, but like that one this should wait to merge until the internal change is ready.
In order to have proper validation for Workflows I think we will need a similar setup as DOs: ValidationErrorReporter now has a `addWorkflowClass` that behaves similarily as `addActorClass`. (This will need a internal PR in order to work properly). This will be useful in cases that a user exports a class but doesn't extend from `WorkflowEntrypoint` (meaning they won't get `ctx` and `env` and see weird errors).
…un` handler We also want to validate if the exported workflows has the `run` handler in the provided class entrypoint. I use the same approach as the exported stateless classes: by introspecting the prototypes of the workflow class.
LuisDuarte1
force-pushed
the
lduarte/workflows-validator
branch
from
30a5ba3 to
169a95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have proper validation for Workflows I think we will need a similar setup as DOs: ValidationErrorReporter now has a
addWorkflowClassthat behaves similarily asaddActorClass. (This will need a internal PR in order to work properly).This will be useful in cases that a user exports a class but doesn't extend from
WorkflowEntrypoint(meaning they won't getctxandenvand see weird errors).