Change PipelineTransform to PipelineTransformationEntrypoint #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshwarip
reviewed
Feb 14, 2025
cmackenzie1
suggested changes
Feb 18, 2025
hhoughgg
force-pushed
the
hhoughgg/pipeline-transformation
branch
from
fc16ad2 to
ca3e687
Compare
cmackenzie1
reviewed
Feb 19, 2025
oliy
reviewed
Feb 19, 2025
oliy
approved these changes
Feb 19, 2025
|
lgtm, excited for this :) |
hhoughgg
force-pushed
the
hhoughgg/pipeline-transformation
branch
from
ca3e687 to
a00ba7a
Compare
cmackenzie1
approved these changes
Feb 19, 2025
a-robinson
approved these changes
Feb 20, 2025
|
@hhoughgg are you able to view the failing CI checks and fix them up? I can merge for you once they're green, but given the number of failures it looks like some fixing is needed. |
hhoughgg
force-pushed
the
hhoughgg/pipeline-transformation
branch
from
a00ba7a to
a24e4ea
Compare
|
Looks like there's still an issue? |
auto-merge was automatically disabled
February 21, 2025 17:07
Head branch was pushed to by a user without write access
yj7o5
pushed a commit
to yj7o5/workerd
that referenced
this pull request
Feb 25, 2025
…are#3543) * Change PipelineTransform to PipelineTransformationEntrypoint class implementation * generate new type snapshots
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the implementation here to make it so that instead of having different functions for different datatypes such as transformJson(), we instead have different entrypoints.
Nothing in this change is backwards compatible and involves changes to generated-types. This is for an unreleased product and not being used except internally, so breaking changes are ok in this context.