Implement Response.error() #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
changed the title
anonrig
reviewed
Feb 22, 2025
|
The generated output of |
anonrig
approved these changes
Feb 24, 2025
| // determined that only the `'default'` and `'error'` properties should be implemented. | ||
| // We currently due not implement Response.error() so "default" is the only value we | ||
| // currently support. | ||
| kj::StringPtr getType() { |
There was a problem hiding this comment.
Suggested change
| kj::StringPtr getType() { | |
| kj::StringPtr getType() const { |
jasnell
force-pushed
the
jasnell/fetch-response-error
branch
2 times, most recently
from
2adfe46 to
27b5944
Compare
Signed-off-by: James M Snell <jsnell@cloudflare.com>
jasnell
force-pushed
the
jasnell/fetch-response-error
branch
from
27b5944 to
b68c8a6
Compare
|
Internal PR passed CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3590 to implement
Response.error().WinterTC will be including
Response.error()is the fetch subset that compliant runtimes should implement, andResponse.error()is necessary for nodejs_compat.Fixes: #3591