Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a giant one (and it's still a draft), so I'd suggest reviewing commit-by-commit.
Improvements to Bazel config for WPT tests:
Improvements to the test harness:
assert_greater_than
,assert_regexp_match
,promise_rejects_js
,promise_rejects_exactly
,add_cleanup
/add_completion_callback
.Added a config file for the fetch/api tests.
We fail most of them. Here's a really quick summary of why:
Response.type
to basic in a lot of cases, we forget to put a space inmultipart/form-data;boundary=whatevs
, we force ReadableStreams to explicitly settype: undefined
instead of allowing a missing property, and such.Invalid response status line (invalid protocol).
messages, and they don't seem to actually be associated with the request that caused them. I'm still looking into this. Curious if ASan sees anything...Next step
bazel test
. I'll need to use @anonrig's sidecar option to launch the wpt server before the tests are run.sidecar
(I'll create an issue for this.)