Backport WriteUtf8V2 patch from v8 13.5 #3697
Merged
+206
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure, but other than the 00000 changes, LGTM |
danlapid
reviewed
Mar 12, 2025
ketanhwr
force-pushed
the
ketan/backport-writeutf-v8
branch
from
8773c87 to
50714a2
Compare
erikcorry
approved these changes
Mar 12, 2025
ketanhwr
force-pushed
the
ketan/backport-writeutf-v8
branch
from
50714a2 to
b297a38
Compare
ketanhwr
force-pushed
the
ketan/backport-writeutf-v8
branch
from
8740df2 to
9a6196c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why rest of the patches also got updated, I just followed the v8-updates.md doc and cherry-picked @anonrig's commit