Add Github Actions #117
Closed
Add Github Actions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. Maybe can you split this up into 2 PRs though? One containing the fixes, and then another with the Actions? That way we can merge the fixes, and then the Actions (maybe just the Linter first, so the checks pass, and then the integration tests once we figure out what's going wrong). |
|
Closing to break it up into multiple PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Github Actions to automatically test pull requests by running
worker-sandboxthrough miniflare. Initially this usedwrangler publishandwrangler devbut I ran into some unresolved issues in wrangler, so it might be a good idea to switch to wrangler2 once it's stabilized.This PR also goes through and fixes all the places clippy complained as I thought it'd be good to add a linter test, but a recent wasm-bindgen bug has caused it to generate code that emits a clippy error so it is disabled for now.
Merging this would require we set up a
CF_API_TOKENsecret, the tests will fail until then.Fixes #58