Optionally run Response Promise to completion in waitUntil context #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client disconnects, code is not run to clean up
wasm-bindgen's "heap", and thus objects associated with the request leak.wasm-bindgensuggests the use ofFinalizationRegistry, which we do not currently support due to security reasons.This change allows user's to specify
RUN_TO_COMPLETIONenvironment variable when runningworker-build, which tricks the Workers runtime into executing the Promise that resolves the Response in awaitUntilcontext, even if the client disconnects. This should be used with caution, as your code may have side effects that you would not want to run if the client disconnects.Below is a graph of Wasm heap usage over time during a load test, first with existing behavior, and second with
RUN_TO_COMPLETIONenabled.