Rename serve_directly to experimental_serve_directly (#7429)

cloudflare · Dec 3, 2024 · 5244faa · 5244faa
1 parent 4f1a46e
commit 5244faa
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.changeset/six-coats-rule.md b/.changeset/six-coats-rule.md
@@ -2,6 +2,6 @@
 "wrangler": minor
 ---
 
-feat: add `serve_directly` option to Workers with Assets
+feat: add `experimental_serve_directly` option to Workers with Assets
 
 Users can now specify whether their assets are served directly against HTTP requests or whether these requests always go to the Worker, which can then respond with asset retrieved by its assets binding.
diff --git a/packages/wrangler/src/__tests__/deploy.test.ts b/packages/wrangler/src/__tests__/deploy.test.ts
@@ -4964,7 +4964,7 @@ addEventListener('fetch', event => {});`
 					binding: "ASSETS",
 					html_handling: "none",
 					not_found_handling: "404-page",
-					serve_directly: false,
+					experimental_serve_directly: false,
 				},
 			});
 			await mockAUSRequest();
@@ -5038,7 +5038,7 @@ addEventListener('fetch', event => {});`
 					binding: "ASSETS",
 					html_handling: "none",
 					not_found_handling: "404-page",
-					serve_directly: true,
+					experimental_serve_directly: true,
 				},
 			});
 			await mockAUSRequest();

diff --git a/packages/wrangler/src/assets.ts b/packages/wrangler/src/assets.ts
@@ -347,7 +347,7 @@ export function processAssetsArg(
 	const assetConfig = {
 		html_handling: config.assets?.html_handling,
 		not_found_handling: config.assets?.not_found_handling,
-		serve_directly: config.assets?.serve_directly,
+		serve_directly: config.assets?.experimental_serve_directly,
 	};
 
 	return {

diff --git a/packages/wrangler/src/config/environment.ts b/packages/wrangler/src/config/environment.ts
@@ -948,7 +948,7 @@ export type Assets = {
 		| "drop-trailing-slash"
 		| "none";
 	not_found_handling?: "single-page-application" | "404-page" | "none";
-	serve_directly?: boolean;
+	experimental_serve_directly?: boolean;
 };
 
 export interface Observability {

diff --git a/packages/wrangler/src/config/validation.ts b/packages/wrangler/src/config/validation.ts
@@ -2176,8 +2176,8 @@ const validateAssetsConfig: ValidatorFn = (diagnostics, field, value) => {
 		validateOptionalProperty(
 			diagnostics,
 			field,
-			"serve_directly",
-			(value as Assets).serve_directly,
+			"experimental_serve_directly",
+			(value as Assets).experimental_serve_directly,
 			"boolean"
 		) && isValid;
 
@@ -2187,7 +2187,7 @@ const validateAssetsConfig: ValidatorFn = (diagnostics, field, value) => {
 			"binding",
 			"html_handling",
 			"not_found_handling",
-			"serve_directly",
+			"experimental_serve_directly",
 		]) && isValid;
 
 	return isValid;