Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Running wrangler dev --local with r2 binding still requires a preview_bucket_name #2462

Closed
Mexassi opened this issue Dec 28, 2022 · 4 comments
Assignees
Labels
bug Something that isn't working discussion This issue is being used to discuss a topic rather than track a feature or bug.

Comments

@Mexassi
Copy link

Mexassi commented Dec 28, 2022

What version of Wrangler are you using?

2.6.1

What operating system are you using?

Mac

Describe the Bug

  1. Create a simple worker with an r2 binding in the toml
  2. Run the worker with wrangler dev --local

Expected Behaviour: It should run the worker and the r2 bucket locally
Actual Behaviour: An error prompts the user to create a bucket and add a preview_bucket_name to the toml config

image

After adding a preview_bucket_name with any value to the toml file, I was able to run the bucket locally.

@Mexassi Mexassi added the bug Something that isn't working label Dec 28, 2022
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 28, 2022
@JacobMGEvans
Copy link
Contributor

I will discuss this with the team however this is likely behavior we would like to keep. It will likely become unneeded once we move --experimental-local to --local

Cc: @mrbbot Thoughts?

@JacobMGEvans JacobMGEvans moved this from Untriaged to Other in workers-sdk Dec 28, 2022
@JacobMGEvans JacobMGEvans self-assigned this Dec 28, 2022
@JacobMGEvans JacobMGEvans added the discussion This issue is being used to discuss a topic rather than track a feature or bug. label Dec 28, 2022
@mrbbot
Copy link
Contributor

mrbbot commented Jan 3, 2023

Hmmm, there's no reason why we need to create a preview bucket on Cloudflare's network for --local mode. We should be able to remove this restriction. The --experimental-local transition won't affect this.

@anarkrypto
Copy link

Now wrangler dev uses local mode by default, --local is no longer required

But it still requiring create a new preview bucket.

@jspspike
Copy link
Contributor

As shown in the issue history this was fixed with #3901 by @DaniFoldi

@github-project-automation github-project-automation bot moved this from Backlog to Done in workers-sdk Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working discussion This issue is being used to discuss a topic rather than track a feature or bug.
Projects
None yet
Development

No branches or pull requests

5 participants