Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw for missing preview ids in local dev mode #3901

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

DaniFoldi
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

#2462 For R2, I couldn't find a GitHub issue for KV.
Tests still don't run for me locally, so there will probably be a couple rounds of workflow fails -> test fixes.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@DaniFoldi DaniFoldi requested a review from a team as a code owner September 7, 2023 08:53
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 6b259ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #3901 (6b259ba) into main (7f60db2) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3901      +/-   ##
==========================================
+ Coverage   75.11%   75.12%   +0.01%     
==========================================
  Files         195      195              
  Lines       11485    11487       +2     
  Branches     3034     3036       +2     
==========================================
+ Hits         8627     8630       +3     
+ Misses       2858     2857       -1     
Files Changed Coverage Δ
packages/wrangler/src/dev.tsx 83.19% <0.00%> (-0.69%) ⬇️

... and 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-wrangler-3901

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6108041635/npm-package-wrangler-3901

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-wrangler-3901 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-cloudflare-pages-shared-3901

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.7.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230904.0 3.20230904.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for the PR! 😃 Pulled down and tested locally, and looks good to me. D1 already seems to do the right thing with database_id/preview_database_id, so no need for changes there. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants