-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw for missing preview ids in local dev mode #3901
Conversation
🦋 Changeset detectedLatest commit: 6b259ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #3901 +/- ##
==========================================
+ Coverage 75.11% 75.12% +0.01%
==========================================
Files 195 195
Lines 11485 11487 +2
Branches 3034 3036 +2
==========================================
+ Hits 8627 8630 +3
+ Misses 2858 2857 -1
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-wrangler-3901 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6108041635/npm-package-wrangler-3901 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-wrangler-3901 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6108041635/npm-package-cloudflare-pages-shared-3901 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! 👋 Thanks for the PR! 😃 Pulled down and tested locally, and looks good to me. D1 already seems to do the right thing with database_id
/preview_database_id
, so no need for changes there. 👍
Fixes # [insert GH or internal issue number(s)].
What this PR solves / how to test:
#2462 For R2, I couldn't find a GitHub issue for KV.
Tests still don't run for me locally, so there will probably be a couple rounds of workflow fails -> test fixes.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.