Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: wrangler@alpha should SIGTERM react-scripts on error #543

Closed
benallfree opened this issue Mar 4, 2022 · 2 comments · Fixed by #671
Closed

🐛 BUG: wrangler@alpha should SIGTERM react-scripts on error #543

benallfree opened this issue Mar 4, 2022 · 2 comments · Fixed by #671
Labels
pages Relating to Pages

Comments

@benallfree
Copy link

What version of Wrangler are you using?

0.0.0-046b17d

What operating system are you using?

Mac

Describe the Bug

 ./node_modules/.bin/wrangler  --version
0.0.0-046b17d

If the following command exits on error for any reason, react-scripts stays running.

./node_modules/.bin/wrangler pages dev -- npx react-scripts start

Subsequent runs will produce:

./node_modules/.bin/wrangler pages dev -- npx react-scripts start
Running npx react-scripts start...
Sleeping 5 seconds to allow proxy process to start before attempting to automatically determine port...
To skip, specify the proxy port with --proxy.
[proxy]: Something is already running on port 3000.

Proxy exited with status 0.
@benallfree benallfree added the bug label Mar 4, 2022
@benallfree
Copy link
Author

Discord convo https://discord.com/channels/595317990191398933/789155108529111069/949419123245465631

@benallfree benallfree changed the title 🐛 BUG: wrangler@alpha does not SIGTERM react-scripts on error 🐛 BUG: wrangler@alpha should SIGTERM react-scripts on error Mar 4, 2022
@petebacondarwin petebacondarwin added the pages Relating to Pages label Mar 7, 2022
@threepointone threepointone mentioned this issue Mar 16, 2022
Closed
@GregBrimble
Copy link
Contributor

This only happens when the initial Functions compilation fails. We've got a fix. Putting up a PR shortly...

@GregBrimble GregBrimble mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pages Relating to Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't immediately exit on Pages Functions compilation error cloudflare/workers-sdk
3 participants
@petebacondarwin @benallfree @GregBrimble