-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminate dev test processes with prejudice on exit #620
Conversation
Is there a solution where we actually clean up correctly instead of doing this? What is the source of the hanging processes/ports? |
might be related #543 |
#543 is what I was hinting at where we could use this elsewhere. Inside the |
I really don't want us to install a non trivial dependency for something that seems like we should be getting right. Can we investigate why we're struggling to close this process at all, if you're saying we already have code to do so? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the CI not run?
@@ -29,6 +29,7 @@ | |||
"jest": "^27.5.1", | |||
"npm-run-all": "^4.1.5", | |||
"prettier": "^2.5.1", | |||
"terminate": "2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be here, right?
GitHub actions (and other GitHub services) was having problems yesterday |
Could we resolve this soon-ish please? It's starting to affect builds in CI now too |
New PR up in #670 |
Fixes #397 (and #618)
Kills the dev processes aggressively when jest is finished its tests of the example repos.
Seems a handy utility. Maybe we use it elsewhere as well?