Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: insufficient command line param checking -wrangler tail --pretty doesn't fail #706

Closed
IgorMinar opened this issue Mar 26, 2022 · 2 comments · Fixed by #708 or #679
Closed

🐛 BUG: insufficient command line param checking -wrangler tail --pretty doesn't fail #706

IgorMinar opened this issue Mar 26, 2022 · 2 comments · Fixed by #708 or #679

Comments

@IgorMinar
Copy link
Contributor

What version of Wrangler are you using?

0.0.0-52ea60f

What operating system are you using?

mac

Describe the Bug

I accidentally ran the following:

$ wrangler tail --pretty

and to my surprise it behave in the same way as wrangler tail. I'd expect the command to fail because --pretty is no a valid flag. Could we tighten up the param checks and error when in valid flag is passed in?

This seems to be a wrangler-wide issue because other commands don't mind bogus flags either:

$ wrangler whoami --pretty
 ⛅️ wrangler 0.0.0-52ea60f 
---------------------------
Getting User settings...
👋 You are logged in with an OAuth Token, associated with the email '...'!
@IgorMinar IgorMinar added the bug label Mar 26, 2022
@threepointone
Copy link
Contributor

Missed this, I'll fix it

threepointone added a commit that referenced this issue Mar 26, 2022
@threepointone
fix: unexpected commands and arguments should throw
30c705f 
This enables strict mode in our command line parser (yargs), so that unexpected commands an options uniformly throw errors.

Fixes #706
@threepointone threepointone mentioned this issue Mar 26, 2022
Merged
@threepointone
Copy link
Contributor

Fix in #708

threepointone added a commit that referenced this issue Mar 26, 2022
@threepointone
fix: unexpected commands and arguments should throw
2297a85 
This enables strict mode in our command line parser (yargs), so that unexpected commands and options uniformly throw errors.

Fixes #706
threepointone added a commit that referenced this issue Mar 26, 2022
@threepointone
fix: unexpected commands and arguments should throw (#708)
763dcb6 
This enables strict mode in our command line parser (yargs), so that unexpected commands and options uniformly throw errors.

Fixes #706
@github-actions github-actions bot mentioned this issue Mar 26, 2022
Merged
mrbbot added a commit that referenced this issue Oct 31, 2023
@mrbbot
Use existing //# sourceURL comments if present (#706)
6742744 
With Wrangler's new `find_additional_modules` support, there are
cases where we'd like `//# sourceURL` not to be resolved from the
module name/path. This change makes sure we don't insert this
comment if it's already present, so Wrangler can add it.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Use existing //# sourceURL comments if present (#706)
2ebdf31 
With Wrangler's new `find_additional_modules` support, there are
cases where we'd like `//# sourceURL` not to be resolved from the
module name/path. This change makes sure we don't insert this
comment if it's already present, so Wrangler can add it.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Use existing //# sourceURL comments if present (#706)
7530e7e 
With Wrangler's new `find_additional_modules` support, there are
cases where we'd like `//# sourceURL` not to be resolved from the
module name/path. This change makes sure we don't insert this
comment if it's already present, so Wrangler can add it.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Use existing //# sourceURL comments if present (#706)
5a9b91f 
With Wrangler's new `find_additional_modules` support, there are
cases where we'd like `//# sourceURL` not to be resolved from the
module name/path. This change makes sure we don't insert this
comment if it's already present, so Wrangler can add it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@threepointone @IgorMinar