Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement support for [data_blobs]/Data modules for service-workers #740

Closed
threepointone opened this issue Mar 31, 2022 · 4 comments · Fixed by #756 or #721
Closed

feat: Implement support for [data_blobs]/Data modules for service-workers #740

threepointone opened this issue Mar 31, 2022 · 4 comments · Fixed by #756 or #721
Assignees
@threepointone

Comments

@threepointone
Copy link
Contributor

Turns out we do actually have internal support for binding a data_blob to a service worker. We should leverage it and add data_blobs/Data module support for service-workers.
@threepointone threepointone moved this to Should-have in workers-sdk Mar 31, 2022
@threepointone threepointone added this to the 2.0 milestone Mar 31, 2022
@threepointone
Copy link
Contributor Author

I don't think this is critical for 2.0 (since no one uses it at all anyway), but would be nice to have to round out the module system support. Added it to the 2.0 milestone anyway.

@threepointone threepointone mentioned this issue Mar 31, 2022
Merged
@threepointone
Copy link
Contributor Author

And of course, we should also add support in miniflare for this.

@threepointone threepointone mentioned this issue Mar 31, 2022
Closed
threepointone added a commit that referenced this issue Mar 31, 2022
@threepointone
feat: implement [data_blobs]
0ed22cd 
This implements `[data_blobs]` support for service-worker workers, as well as enabling Data module support for service-worker workers. `data_blob` is a supported binding type, but we never implemented support for it in v1. This implements support, and utilises it for supporting Data modules in service worker format. Implementation wise, it's incredibly similar to how we implemented `text_blobs`, with relevant changes.

Partial fix for #740, pending local mode support.
threepointone added a commit that referenced this issue Mar 31, 2022
@threepointone
feat: implement [data_blobs]
cb2c1e3 
This implements `[data_blobs]` support for service-worker workers, as well as enabling Data module support for service-worker workers. `data_blob` is a supported binding type, but we never implemented support for it in v1. This implements support, and utilises it for supporting Data modules in service worker format. Implementation wise, it's incredibly similar to how we implemented `text_blobs`, with relevant changes.

Partial fix for #740, pending local mode support.
@threepointone threepointone mentioned this issue Mar 31, 2022
Merged
threepointone added a commit that referenced this issue Mar 31, 2022
@threepointone
feat: implement [data_blobs] (#743)
ac5c48b 
This implements `[data_blobs]` support for service-worker workers, as well as enabling Data module support for service-worker workers. `data_blob` is a supported binding type, but we never implemented support for it in v1. This implements support, and utilises it for supporting Data modules in service worker format. Implementation wise, it's incredibly similar to how we implemented `text_blobs`, with relevant changes.

Partial fix for #740, pending local mode support.
@github-actions github-actions bot mentioned this issue Mar 31, 2022
Merged
@threepointone
Copy link
Contributor Author

threepointone commented Apr 1, 2022 •
edited
Loading

Filed cloudflare/miniflare#231 with an implementation PR cloudflare/miniflare#232 for miniflare

@petebacondarwin petebacondarwin moved this from Should-have to In Progress in workers-sdk Apr 2, 2022
@petebacondarwin petebacondarwin moved this from In Progress to Should-have in workers-sdk Apr 2, 2022
@threepointone
Copy link
Contributor Author

Pending #416 (comment)

threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in local mode
d046b92 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths so that they're ersolveds correctly by miniflare.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in local mode
963b28d 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths so that they're ersolveds correctly by miniflare.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
906a62b 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as asbolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
5ceb295 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
@threepointone threepointone mentioned this issue Apr 4, 2022
Merged
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
3869d2c 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
@petebacondarwin petebacondarwin moved this from Should-have to In Review in workers-sdk Apr 4, 2022
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
8853ba4 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
8a00710 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode
46ff829 
For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
threepointone added a commit that referenced this issue Apr 4, 2022
@threepointone
fix: resolve raw file bindings correctly in wrangler dev local mode (…
8e38442 
…#756)

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`.

Fixes #740
Fixes #416
Repository owner moved this from In Review to Done in workers-sdk Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@threepointone