Update config after creation commands

[penalosa]

Fixes #9730

When running a resource creation command (like wrangler kv namespace create NAME), Wrangler will now offer to update your config file for you. Some notes:

• This does not work for preview KV namespaces, as we don't know the right main KV ID to use
• This does work for environments, and will update the relevant resource field in the given environment (i.e. --env test)
• Wrangler will prompt with 3 options: Yes, Yes but change the binding name (which will then present a second dialog to choose the binding name), or No
• This will not work in non-interactive contexts like CI
• This will not work when running Wrangler in a context that can't find a config file
• Updating the config file only works for jsonc format

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: this doesn't need additional documentation
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: new feature

[changeset-bot]

🦋 Changeset detected

Latest commit: ae956e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Minor
@cloudflare/vite-plugin	Major
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10414

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10414

miniflare

npm i https://pkg.pr.new/miniflare@10414

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10414

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10414

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10414

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10414

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10414

wrangler

npm i https://pkg.pr.new/wrangler@10414

commit: ae956e3

[dario-piotrowicz]

Looks good to me 😄 I just left a few small comments

Possibly I would also suggest two additional tests:

• a test with a toml file testing that the promp is not being presented
• a test showing that the promp and modification also works as intended with jsonc files with comments (although this might be a bit redundant since already tested for experimental_patchConfig? 🤔 )

[dario-piotrowicz]

Sorry... this is completely completely unrelated, but probably as a followup, I think it's be nicer to use an emoji for the question mark (like❔ for example), what do you think? 🙂

[penalosa]

The TOML case is tested here:

workers-sdk/packages/wrangler/src/__tests__/update-config-file.test.ts

Line 194 in cc24a58

\\"ai\\": {

, howing no prompts & no config updates. I could add an additional test for a file with comments, but as you say I think it might be a bit redundant given experimental_patchConfig() is already tested with that case.

[dario-piotrowicz]

The TOML case is tested here:

Sorry, somehow I missed that! 🤦 🙇

I could add an additional test for a file with comments, but as you say I think it might be a bit redundant given experimental_patchConfig() is already tested with that case.

I don't have a strong opinion on it either, if you think it's unnecessary I'm ok avoiding it 🙂👍

[dario-piotrowicz]

Looks good to me 😄