-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update C3 templates to use Durable Object getByName #10419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2bed5bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the change! 🚀
I wasn't aware of this new getByName API, it looks so much better! 🫶
Not approving only because I think that some say_hello methods need to be renamed to sayHello, please have a quick look 🙏
packages/create-cloudflare/templates/hello-world-durable-object-with-assets/py/src/entry.py
Outdated
Show resolved
Hide resolved
packages/create-cloudflare/templates/hello-world-durable-object/py/src/entry.py
Show resolved
Hide resolved
d81a1f6 to
2bed5bd
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, sorry I forgot that in python camel case is the convention, thanks for reverting the comment 🙏
Looks good to me! 😄
Fixes #[insert GH or internal issue link(s)].
Update C3 templates to use Durable Object getByName