Skip to content

Conversation

@joshthoward
Copy link
Contributor

@joshthoward joshthoward commented Aug 20, 2025

Fixes #[insert GH or internal issue link(s)].

Update C3 templates to use Durable Object getByName

@joshthoward joshthoward requested a review from a team as a code owner August 20, 2025 18:51
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

🦋 Changeset detected

Latest commit: 2bed5bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10419

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10419

miniflare

npm i https://pkg.pr.new/miniflare@10419

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10419

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10419

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10419

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10419

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10419

wrangler

npm i https://pkg.pr.new/wrangler@10419

commit: 2bed5bd

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the change! 🚀

I wasn't aware of this new getByName API, it looks so much better! 🫶

Not approving only because I think that some say_hello methods need to be renamed to sayHello, please have a quick look 🙏

@joshthoward joshthoward force-pushed the jhoward/c3-do-getByName branch from d81a1f6 to 2bed5bd Compare August 21, 2025 18:12
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, sorry I forgot that in python camel case is the convention, thanks for reverting the comment 🙏

Looks good to me! 😄

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 21, 2025
@dario-piotrowicz dario-piotrowicz merged commit 7d314b1 into main Aug 21, 2025
37 of 40 checks passed
@dario-piotrowicz dario-piotrowicz deleted the jhoward/c3-do-getByName branch August 21, 2025 20:38
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants