feat: --assets / config.assets to serve a folder of static assets
#1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d71d3f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2516392147/npm-package-wrangler-1237You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1237/npm-package-wrangler-1237Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2516392147/npm-package-wrangler-1237 dev path/to/script.js |
threepointone
force-pushed
the
config-assets
branch
from
fbefa20
to
d9019b5
Compare
mangs
reviewed
Jun 16, 2022
threepointone
force-pushed
the
config-assets
branch
3 times, most recently
from
ca94b13
to
fef6023
Compare
threepointone
changed the title
--assets / config.assets to serve a folder of static assets--assets / config.assets to serve a folder of static assets
rozenmd
reviewed
Jun 16, 2022
rozenmd
reviewed
Jun 16, 2022
rozenmd
reviewed
Jun 16, 2022
threepointone
force-pushed
the
config-assets
branch
from
fef6023
to
8aa41bf
Compare
JacobMGEvans
approved these changes
Jun 16, 2022
|
I'm going add an experimental warning on this and land it |
threepointone
force-pushed
the
config-assets
branch
from
8aa41bf
to
fdcb02f
Compare
This adds support for defining `assets` in `wrangler.toml`. You can configure it with a string path, or a `{bucket, include, exclude}` object (much like `[site]`). This also renames the `--experimental-public` arg as `--assets`.
Via #1162
threepointone
force-pushed
the
config-assets
branch
from
fdcb02f
to
d71d3f0
Compare
Merged
|
Hooray! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for defining
assetsinwrangler.toml. You can configure it with a string path, or a{bucket, include, exclude}object (much like[site]). This also renames the--experimental-publicarg as--assets.Via #1162
Followup tasks (I'll make issues for each of these later, but logging here for visibility)
--assetsfor service-worker Workers #1295){cacheControl: { browserTTL: number, edgeTTL: number, bypassCache: boolean }, singlePageApp: boolean }_headers--assets/config.assetsis used (feat: entry point is not mandatory if--assetsis passed #1289)