Skip to content

Service bindings in Pages #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 19, 2023

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Nov 11, 2022

fixes #3053

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

🦋 Changeset detected

Latest commit: 1393e43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-wrangler-2162

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6573867593/npm-package-wrangler-2162

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-wrangler-2162 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-cloudflare-pages-shared-2162

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.13.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231016.0 3.20231016.0
workerd 1.20231016.0 1.20231016.0
workerd --version 1.20231016.0 2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #2162 (1393e43) into main (980df04) will decrease coverage by 0.05%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
- Coverage   75.41%   75.37%   -0.05%     
==========================================
  Files         223      223              
  Lines       12231    12247      +16     
  Branches     3161     3168       +7     
==========================================
+ Hits         9224     9231       +7     
- Misses       3007     3016       +9     
Files Coverage Δ
packages/wrangler/src/api/dev.ts 82.60% <ø> (ø)
packages/wrangler/src/dev.tsx 83.60% <100.00%> (+0.06%) ⬆️
packages/wrangler/src/pages/dev.ts 15.97% <13.33%> (-0.15%) ⬇️

... and 3 files with indirect coverage changes

@GregBrimble
Copy link
Contributor

We have a fixture used for DOs which you could copy: https://github.com/cloudflare/wrangler2/tree/main/fixtures/external-durable-objects-app

@WalshyDev WalshyDev force-pushed the walshy/PAGES-1929-service-bindings-in-pages branch from 0159b78 to 4806aaf Compare November 18, 2022 16:41
@petebacondarwin petebacondarwin added the pages Relating to Pages label Jan 12, 2023
@rfire12
Copy link

rfire12 commented Mar 26, 2023

@WalshyDev Will this be released any time soon?

The documentation has been out of date for a while:

@JorritSalverda
Copy link

Would be brilliant if this gets released. Any ETA?

@code-poel
Copy link

Is there any quick work-around for being able to bind a worker to a page application locally in the mean time?

@petebacondarwin
Copy link
Contributor

Is there any quick work-around for being able to bind a worker to a page application locally in the mean time?

Could you move the shared logic that you want to service bind to into a separate Worker of its own, then service bind to it from the Pages project and from any other Workers where it is needed?

@dario-piotrowicz dario-piotrowicz force-pushed the walshy/PAGES-1929-service-bindings-in-pages branch from 4806aaf to adfa3e7 Compare October 11, 2023 15:36
@WalshyDev WalshyDev requested a review from a team as a code owner October 11, 2023 15:36
@dario-piotrowicz dario-piotrowicz force-pushed the walshy/PAGES-1929-service-bindings-in-pages branch from 56d3aa0 to 3e7e614 Compare October 11, 2023 15:52
Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick skim looks good, but need to go over it in a bit more detail later.

Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for being patient and making all those refinements!

Verified

This commit was signed with the committer’s verified signature.
juanitorduz Juan Orduz
@dario-piotrowicz dario-piotrowicz force-pushed the walshy/PAGES-1929-service-bindings-in-pages branch from 5153ccb to 5c204d4 Compare October 19, 2023 11:08
@petebacondarwin petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Oct 19, 2023
@dario-piotrowicz dario-piotrowicz merged commit a1f212e into main Oct 19, 2023
@dario-piotrowicz dario-piotrowicz deleted the walshy/PAGES-1929-service-bindings-in-pages branch October 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: --service options missing in wrangler pages dev
7 participants