-
Notifications
You must be signed in to change notification settings - Fork 888
Service bindings in Pages #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service bindings in Pages #2162
Conversation
🦋 Changeset detectedLatest commit: 1393e43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-wrangler-2162 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6573867593/npm-package-wrangler-2162 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-wrangler-2162 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6573867593/npm-package-cloudflare-pages-shared-2162 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
- Coverage 75.41% 75.37% -0.05%
==========================================
Files 223 223
Lines 12231 12247 +16
Branches 3161 3168 +7
==========================================
+ Hits 9224 9231 +7
- Misses 3007 3016 +9
|
We have a fixture used for DOs which you could copy: https://github.com/cloudflare/wrangler2/tree/main/fixtures/external-durable-objects-app |
0159b78
to
4806aaf
Compare
@WalshyDev Will this be released any time soon? The documentation has been out of date for a while: |
Would be brilliant if this gets released. Any ETA? |
Is there any quick work-around for being able to bind a worker to a page application locally in the mean time? |
Could you move the shared logic that you want to service bind to into a separate Worker of its own, then service bind to it from the Pages project and from any other Workers where it is needed? |
4806aaf
to
adfa3e7
Compare
56d3aa0
to
3e7e614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick skim looks good, but need to go over it in a bit more detail later.
f3e6470
to
5153ccb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for being patient and making all those refinements!
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
5153ccb
to
5c204d4
Compare
fixes #3053